QuestionHelper - disableStty is static method
#8111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 3, 2017
SpacePossum
changed the title
disableStty is static methoddisableStty is static method
javiereguiluz
approved these changes
Jul 4, 2017
|
Thank you @SpacePossum. |
xabbuh
added a commit
that referenced
this pull request
Jul 4, 2017
…sum) This PR was merged into the 3.3 branch. Discussion ---------- QuestionHelper - `disableStty` is static method The docs suggest disabling stty must be done on each instance of `QuestionHelper`, however it is a static method setting a static property, i.e. it effects _all_ instances. Besides, its always a good idea to call `static` methods using the `static` call syntax. Commits ------- c48d595 Update questionhelper.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs suggest disabling stty must be done on each instance of
QuestionHelper, however it is a static method setting a static property, i.e. it effects all instances.Besides, its always a good idea to call
staticmethods using thestaticcall syntax.